Fix show user name on answers #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a table join in order to access the user's name. Added a testData method in order to access the user over the in memory db. TestData creates the users table and adds an user to it, in order for me to have access to it on my unit tests. The getAnswersByQuestion method is still fully tested and working. User's name now is displayed on the front-end
The getAnswersByQuestion method wasn't fully tested. It was missing bad data tests. It is now 100% tested
The method would throw an error when the results of the SQL query was empty. However it is possible for a question to have no answers Therefore this error was unecessary and would break the application
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
User's name now is displayed on the front-end, instead of the user id