. #1
Merged
. #1
+623
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt code for students for new feature
Merge Cucumber Exercises into Master
This is the start of the lab on acceptance testing. So far it covers the basics of puppeteer and basic profiling.
Cucumber Updates
Removed Activity section from README, deprecated
Some students were getting confused about how to solve task 4.2.4 The instructions should now make it easier for them to solve the problem.
The number of lines per function was too short. The linter didn't pick up on poor brace positioning. Linter now fixed.
The step definition file contained a lot of helper code. The page object is now instantiated using a custom object. A several helper functions removed and code moved to steps.
manifest still had a lot of scripts that were no longer needed. These have now been removed.
Scenario bug
|
yes this done |
ngussed
pushed a commit
that referenced
this pull request
Nov 12, 2019
Merge pull request #1 from web/master
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.