syncing fork repo #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating foundation
Lab did not explain how to install git on different OS. Now covers how to install git on MacOS using either Xcode or HomeBrew. Covers apt command for Ubuntu and reminds not to install any GUI tools.
There were some files in the root of the codee quality lab. These have now been put in a directory called linting.
The exercise was unclear. Exercise is now based on the todo files which have been updated
There was an issue with the existing code (logical error) Code has been rewritten to allow for multiple input prompts.
The nested callback exercise did not match the updated code Lab exercise has now been revised to match
Minor amendments were needed
changed the wording of a specific section
The lab code was fixed in a previous commit however the exercise still referred to the old code. The lab notes have been updated to reflect the new, working, script.
The existing promises lab does not work correctly. Added a simple working example that can be used to fix the issues with the lab exercise.
Promises were not resolving in order due to missing returns on resolve. This has now been fixed.
There was some confusion over the impelmentation and the existing import didn't work. The new version resolves the import issue and clarifies the task requirements
Some of the sections didn't have an exercise. Now all sections include one or more tasks to be complete.
The todo script would not run because there was a conflict between the imported object and the local array. The object call was removed and added to the lab activity and the comment on the array clarified.
Currently there is no message to state that the server is running. Added a message to the callback function to display the message with port number.
amended type "is is" in 3.3
explain-context
….js, added content about package.json to 02 HTTP.md, created 02/01/package.json
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.